Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsafe shell command in luigi/contrib/lsf.py #3307

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix unsafe shell command in luigi/contrib/lsf.py #3307

merged 2 commits into from
Sep 5, 2024

Commits on Sep 4, 2024

  1. Fix unsafe shell command in luigi/contrib/lsf.py 

    Fixes spotify#3304

Update `track_job` function to use `shell=False` in `subprocess.Popen` call.

* Change the `cmd` variable to be a list of arguments instead of a single string.
* Set the `shell` parameter to `False` in the `subprocess.Popen` call.
    @Ali-Razmjoo
    Ali-Razmjoo committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bc0855c View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch 'master' into fix-shell-command

    @dlstadther
    dlstadther authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    31e5c9f View commit details
    Browse the repository at this point in the history