Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable test for backwards compatibilty in DB IT #6075

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable test for backwards compatibilty in DB IT #6075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...org/springframework/cloud/dataflow/integration/test/db/AbstractPostgresDatabaseTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import java.net.URISyntaxException;

import com.fasterxml.jackson.databind.ObjectMapper;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -79,15 +80,16 @@ public void migrationError() {
@SuppressWarnings("deprecation")
@Test
@DataflowMain
public void migration210211() throws URISyntaxException {
@Disabled("Reactivate when 3.1 is released")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind explaining in the PR description why we are disabling it?

public void migration30_31() throws URISyntaxException {
log.info("Running testMigrationError()");
this.dataflowCluster.startSkipperDatabase(getDatabaseTag());
this.dataflowCluster.startDataflowDatabase(getDatabaseTag());

this.dataflowCluster.startSkipper(TagNames.SKIPPER_2_9);
this.dataflowCluster.startSkipper(TagNames.SKIPPER_3_0);
assertSkipperServerRunning(this.dataflowCluster);

this.dataflowCluster.startDataflow(TagNames.DATAFLOW_2_10);
this.dataflowCluster.startDataflow(TagNames.DATAFLOW_3_0);
assertDataflowServerRunning(this.dataflowCluster);

ObjectMapper objectMapper = new ObjectMapper();
Expand Down
Loading