Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deprecated Redis Command #3339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Deprecated Redis Command #3339

wants to merge 1 commit into from

Conversation

onjik
Copy link

@onjik onjik commented Apr 6, 2024

Redis' SETEX command is deprecated

I actually used this replacement in my project, and it worked successfully.
I am sending this request in case the command will not work in the future.

Thank you

https://redis.io/commands/setex/
As of Redis version 2.6.12, this command is regarded as deprecated.
It can be replaced by SET with the EX argument when migrating or writing new code.

@spencergibb
Copy link
Member

@mp911de thoughts on this change?

@spencergibb
Copy link
Member

I think it is straightforward looking at the redis docs.

@mp911de
Copy link
Member

mp911de commented Apr 11, 2024

All good here. SET … EX was introduced with Redis 2.6, right now we're at 7.2 so I don't have any compatibility concerns.

@onjik
Copy link
Author

onjik commented Apr 15, 2024

@spencergibb
Could you please re-do the workflow approval?
Thank you.

@onjik
Copy link
Author

onjik commented Apr 18, 2024

Hi @spencergibb

Is there anything else I need to do to be merged or allocated milestones?

Thank you😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants