Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for streaming response modification #3477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added support for streaming response modification #3477

wants to merge 1 commit into from

Conversation

usrivastava92
Copy link
Contributor

Description

This issue has been open for almost 3 years now, multiple PRs have been raised and been rejected / closed. This PR another attempt to fix this issue.
Spring cloud gateway ModifyResponse filter blocks the calls in case of streaming responses.

Fixes gh-2275

FIx

  • The fix introduces separate rewrite function to for modification of streaming and non streaming responses.
  • To keep the changes backwards compatible the old rewrite function has not been removed and has been marked as deprecated

@usrivastava92
Copy link
Contributor Author

Hi @spencergibb please review the PR and let me know your thoughts on this.

@usrivastava92 usrivastava92 changed the title * added support for streaming response modification Added support for streaming response modification Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting-for-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModifyResponseBodyGatewayFilterFactory block SSE response until events are finished
2 participants
@usrivastava92 @spring-cloud-issues