Skip to content

Commit

Permalink
Addressing PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
sobychacko committed May 16, 2024
1 parent 5c79be2 commit f719f8d
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,14 @@ It is only recommended to use for testing purposes in this version.
Therefore, Spring for Apache Kafka supports this new consumer group protocol only to the extent of such testing level support available in the `kafka-client` itself.
By default, Spring for Apache Kafka uses the classic consumer group protocol and when testing the new consumer group protocol, that needs to be opted-in via the `group.protocol` property on the consumer.

When using the `EmbeddedKafka` with the 3.7.0 version of the `kafka-client`, the `kraft` mode is disabeld by default.
This is due to certain instabilities observed while using `EmbeddedKafka` with `kraft` enabled, especially when testing the new consumer group protocol.
In addition, there were some other race conditions observed, while running multiple `KafkaListener` methods with `EmbeddedKafka` in `kraft` mode in this version.
Due to these reasons, when trying `EmbeddedKafka` with `kraft`, that needs to be explicitly opted-in by setting `kraft` to `true`.
[[x32-testing-support-changes]]
=== Testing Support Changes

The `kraft` mode is disabled in `EmbeddedKafka` by default and users wanting to use the `kraft` mode must enable it.
This is due to certain instabilities observed while using `EmbeddedKafka` in `kraft` mode, especially when testing the new consumer group protocol.
The new consumer group protocol is only supported in `kraft` mode and because of this, when testing the new protocol, that needs to be done against a real Kafka cluster and not the one based on the `KafkaClusterTestKit`, which `EmbeddedKafka` is based upon.
In addition, there were some other race conditions observed, while running multiple `KafkaListener` methods with `EmbeddedKafka` in `kraft` mode.
Until these issues are resolved, the `kraft` default on `EmbeddedKafka` will remain as `false`.

[[x32-kafka-streams-iqs-support]]
=== Kafka Streams Interactive Query Support
Expand Down

0 comments on commit f719f8d

Please sign in to comment.