Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more whats-new for kakfa-client 3.7.0 #3253

Merged
merged 2 commits into from
May 16, 2024
Merged

Adding more whats-new for kakfa-client 3.7.0 #3253

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c79be2
Adding more whats-new for kakfa-client 3.7.0
sobychacko May 16, 2024
f719f8d
Addressing PR review
sobychacko May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions spring-kafka-docs/src/main/antora/modules/ROOT/pages/whats-new.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,17 @@ For changes in earlier version, see xref:appendix/change-history.adoc[Change His
=== Kafka Client Version

This version requires 3.7.0 `kafka-clients`.
The 3.7.0 version of Kafka client introduces the new consumer group protocol.
Fore more details and it's limitations see https://cwiki.apache.org/confluence/display/KAFKA/The+Next+Generation+of+the+Consumer+Rebalance+Protocol+%28KIP-848%29+-+Early+Access+Release+Notes[KIP-848].
The new consumer group protocol is an early access release and not meant to be used in production.
It is only recommended to use for testing purposes in this version.
Therefore, Spring for Apache Kafka supports this new consumer group protocol only to the extent of such testing level support available in the `kafka-client` itself.
By default, Spring for Apache Kafka uses the classic consumer group protocol and when testing the new consumer group protocol, that needs to be opted-in via the `group.protocol` property on the consumer.

When using the `EmbeddedKafka` with the 3.7.0 version of the `kafka-client`, the `kraft` mode is disabeld by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence does not reflect reality.
We have it kraft = false compiled-in. Independently of the Kafka client.

I would suggest to have a dedicated bullet for the Testing Support Changes and explain there why we turned it off.
But I believe that has nothing to do with Kafka client 3.7.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, i hear your point. I actually thought about it. However, the new consumer-group protocol testing with EmbeddedKafka in kraft mode may still be relevant here. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there is catch 22. The new consumer group protocol works only in KRaft mode.
And unfortunately, only with real broker, not one created by the KafkaClusterTestKit.
Then we also saw some flaws for classic group management in KRaft mode.
So, this or other way kraft mode is not recommended with @EmbeddedKafka.

This is due to certain instabilities observed while using `EmbeddedKafka` with `kraft` enabled, especially when testing the new consumer group protocol.
In addition, there were some other race conditions observed, while running multiple `KafkaListener` methods with `EmbeddedKafka` in `kraft` mode in this version.
Due to these reasons, when trying `EmbeddedKafka` with `kraft`, that needs to be explicitly opted-in by setting `kraft` to `true`.

[[x32-kafka-streams-iqs-support]]
=== Kafka Streams Interactive Query Support
Expand Down