Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3697: DelegatingInvocableHandler.invoke() returning null #3710

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ivamly
Copy link
Contributor

@ivamly ivamly commented Jan 16, 2025

Fixes: #3697

Change the logic in the DelegatingInvocableHandler.invoke()

@ivamly ivamly marked this pull request as draft January 16, 2025 20:12
@ivamly ivamly marked this pull request as ready for review January 16, 2025 20:22
@ivamly ivamly marked this pull request as draft January 16, 2025 20:29
@sobychacko
Copy link
Contributor

@ivamly Thanks for the PR. There are checkstyle issues in the PR. Please run a full build from the PR branch - .gradlew check. Also, you need to add your name as an author to the class you modified. Finally, see this blog for DCO based commits - https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring. You need to modify the commit message based on that information.

@ivamly
Copy link
Contributor Author

ivamly commented Jan 16, 2025

Thank for the help! I'll do it

…turning null from the DelegatingInvocableHandler.invoke()

Signed-off-by: ivamly <[email protected]>
@ivamly ivamly marked this pull request as ready for review January 16, 2025 22:07
@sobychacko sobychacko merged commit 004fd52 into spring-projects:main Jan 16, 2025
3 checks passed
@sobychacko
Copy link
Contributor

@ivamly Even though it was merged, I realized that this change needs to wait until we break into the new version (4.0.x). We cannot put this in the current versions since it is a breaking change. Sorry about the confusion. @artembilan made that clear in the original description. I will reopen your PR, and then we can tackle this once we branch off into 4.0.x.

@sobychacko
Copy link
Contributor

Actually, i cannot reopen this PR since it was already merged, and we had to back it out. Can you issue another PR based on your latest changes? You can also wait until we branch into the 4.0.x version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize a MessagingMessageListenerAdapter returning null from the DelegatingInvocableHandler.invoke()
2 participants