Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Updated AsyncAPI Kafka binding to version 0.5.0 #672

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

ctasada
Copy link
Collaborator

@ctasada ctasada commented Mar 25, 2024

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for springwolf-ui ready!

Name Link
🔨 Latest commit 6bbc626
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/660a6c587f6bbf0009861dfb
😎 Deploy Preview https://deploy-preview-672--springwolf-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctasada
Copy link
Collaborator Author

ctasada commented Mar 29, 2024

@timonback maybe you know what's happening here?

Looking at npm ls --all I see

├─┬ @asyncapi/[email protected]
│ ├─┬ @asyncapi/[email protected]
│ │ └── @types/[email protected]

Looking at https://github.com/asyncapi/spec-json-schemas/releases/tag/v6.5.3 The spec 6.5.3 added support for Kafka 0.5.0 binding version, but the tests are failing saying that the version is not valid.

@timonback
Copy link
Member

timonback commented Mar 31, 2024

Hi @ctasada
I do not fully understand how the parser works, but as itself does not contain spec files, I checked other places.

Kafka 0.5.0 was recently added in asyncapi/spec-json-schemas#501 and possible forgotten to be added here as well?
EDIT: operationsBindingObject is missing the same addition

I haven’t deeply checked and it is just the first thing I stumble upon. There can be other places as well, or this isn’t the right place at all.

In case you have an idea to get better error message that show at which path the validation fails, let us know/improve the code.

@ctasada
Copy link
Collaborator Author

ctasada commented Mar 31, 2024

https://github.com/asyncapi/parser-js/releases/tag/v3.0.11 is released. Once Dependabot updates this dependency I will rebase this branch

Bumped version to fix Kafka 0.5.0 binding version parsing
@ctasada ctasada merged commit e9b197c into springwolf:master Apr 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants