fix: Style checks #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per README.md we use `valve` to check the documentation style. Sadly this validation was not really working (see https://github.com/springwolf/springwolf.github.io/pull/70/checks for an example) This MR adds the style files and fixes the documentation to pass, using a new accept.txt file
✅ Deploy Preview for springwolf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Still not sure if it's working properly See https://github.com/springwolf/springwolf.github.io/pull/71/checks#step:6:43 |
|
Great that you are looking into it. are all the ms files needed as well? The gh action did sync the files, at least in earlier versions. |
Since Microsoft styles seem to be automatically downloaded, there is no need to push them.
ctasada
force-pushed
the
ctasada/fix-style
branch
from
c65f339 to
1962e4e
Compare
|
@timonback I did some tests:
I think we can consider this MR as done. WDYT |
|
Most importantly: Better than before :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per README.md we use
valveto check the documentation style. Sadly this validation was not really working (see https://github.com/springwolf/springwolf.github.io/pull/70/checks for an example)This MR adds the style files and fixes the documentation to pass, using a new accept.txt file