-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(did-key): Add Support To Resolve JWK_JCS-PUB encoded did:key DIDs #600
Merged
timothee-haudebourg
merged 14 commits into
spruceid:main
from
ianhamilton87:did-key-ebsi
Sep 18, 2024
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
43c9843
feat(did-key): Add EBSI Natural Person Format
ianhamilton87 eaeb8a8
Merge branch 'spruceid:main' into main
ianhamilton87 5faedc3
Revert "feat(did-key): Add EBSI Natural Person Format"
ianhamilton87 5a03909
Merge remote-tracking branch 'origin/main'
ianhamilton87 6c12ad2
feat(did-key): Add EBSI Natural Person Format
ianhamilton87 79c8969
Merge branch 'spruceid:main' into main
ianhamilton87 9f9d5e8
feat(did-key): Add EBSI Natural Person Format
ianhamilton87 cf6984e
Merge remote-tracking branch 'origin/did-key-ebsi' into did-key-ebsi
ianhamilton87 05f0283
feat(did-key): Add EBSI Natural Person Format
ianhamilton87 0ed793a
feat(did-key): Add EBSI Natural Person Format
ianhamilton87 78a6adb
feat(did-key): Add EBSI Natural Person Format
ianhamilton87 c9ec5bc
feat(did-key): Add EBSI Natural Person Format
ianhamilton87 b3b301b
feat(did-key): Add EBSI Natural Person Format
ianhamilton87 9953e2c
feat(did-key): Add EBSI Natural Person Format
ianhamilton87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"crv": "P-256", | ||
"kty": "EC", | ||
"x": "g3fsv1xpWPH099LIUn_zJoOF5Ur8xobyzZwX9m_dJ4E", | ||
"y": "9304UAFl55xQMfrnB-zKEjjXEC4OFWSuYnr7W6hdkVA" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test checking that its able to decode a JWK encoded with the JWK_JCS_PUB multicodec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!