Cleaned up sha256.rs and added test cases #610
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SHA-256 hash function
with a fixed-size 32-byte array andadds test cases.In this version:
Thecopy_from_slice
method is used to convert the hash result (which is always a 32-byte digest) into a fixed-size array. This method is safe and avoids usingunwrap()
or dealing with Result types for conversions.unwrap()
is unsafe because it risks task failure and thus is not a composable error handling mechanism.SHA-256 always produces a 32-byte digest, so an assertion to check the output length was redundant. Removing it simplifies error handling.b"hello world"
and one forb""
, to verify consistency.Edit:
Error handling was unnecessary, so this change now only adds test cases for the hash.