Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VCDM credential subject a non-empty vec #621

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

sbihel
Copy link
Member

@sbihel sbihel commented Oct 25, 2024

@timothee-haudebourg
Copy link
Contributor

A verifiable credential MUST have a credentialSubject property.

In the context of JSON there's a difference between "the property must be there" and "the property must be non-empty". My interpretation of this sentence is "the property must be there" but implicitly it can be empty. Can we have a third opinion? Just to be sure 😅

@sbihel
Copy link
Member Author

sbihel commented Oct 28, 2024

I don't have much of an opinion, it's just from https://w3c-ccg.github.io/vc-api-issuer-test-suite/#Issue%20Credential%20-%20Data%20Integrity

@sbihel sbihel force-pushed the credential_subject_vcdm11 branch from ea10de5 to 228c139 Compare October 28, 2024 18:28
@sbihel sbihel merged commit c921e76 into main Oct 29, 2024
3 checks passed
@sbihel sbihel deleted the credential_subject_vcdm11 branch October 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants