ACP-4189: Payone Paypal Express - Show Express Checkout Buttons on Cart Page. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitskil
changed the title
abitskil
changed the base branch from
master
to
feature/acp-3962/master-paypal-express-checkout
matweew
reviewed
Oct 28, 2024
Comment on lines
+5
to
+7
| import Component from 'ShopUi/models/component'; | ||
| import ScriptLoader from 'ShopUi/components/molecules/script-loader/script-loader'; | ||
| import AjaxLoader from 'ShopUi/components/molecules/ajax-loader/ajax-loader'; |
There was a problem hiding this comment.
add ShopUI to composer.json dependencies.
matweew
reviewed
Oct 28, 2024
|
|
||
| This Agreement constitutes the entire agreement between the parties concerning Licensee’s use of the Software. This Agreement supersedes any prior verbal understanding between the parties. This Agreement may be amended only in a writing signed by an authorized officer of Spryker. | ||
|
|
||
| The MIT License (MIT) |
There was a problem hiding this comment.
Yes, by default the ECO modules are distributed under the MIT license.
pushokwhite
approved these changes
Oct 28, 2024
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="spryker:transfer-01 http://static.spryker.com/transfer-01.xsd"> | ||
|
|
||
| <transfer name="PaypalQueryParameters" strict="true"> |
There was a problem hiding this comment.
Transfer module has to be 3.27.0 at least in composer dependencies.
abitskil
merged commit 4f1a51c
into
feature/acp-3962/master-paypal-express-checkout
0 of 2 checks passed
abitskil
deleted the
feature/acp-4189/display-express-payment-buttons-on-cart-page-part3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://spryker.atlassian.net/browse/ACP-4189