SDK-2745 update tests

spryker-sdk · Aug 14, 2023 · 3972596 · 3972596
1 parent 6670736
commit 3972596
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -10,4 +10,7 @@
             <directory suffix="Test.php">tests/SprykerSdkTest/</directory>
         </testsuite>
     </testsuites>
+    <php>
+        <env name="MANIFESTS_RATING_THRESHOLD" value="0" force="true" />
+    </php>
 </phpunit>
diff --git a/src/Filter/RatingBasedManifestFilter/RatingBasedManifestsFilter.php b/src/Filter/RatingBasedManifestFilter/RatingBasedManifestsFilter.php
@@ -66,11 +66,11 @@ public function filterManifests(array $manifests): array
     {
         $requiredRating = $this->configurationProvider->getManifestsRatingThreshold();
 
-        if ($requiredRating >= static::MAX_RATING_THRESHOLD) {
+        if ($requiredRating <= static::MIN_RATING_THRESHOLD) {
             return $manifests;
         }
 
-        if ($requiredRating <= static::MIN_RATING_THRESHOLD) {
+        if ($requiredRating > static::MAX_RATING_THRESHOLD) {
             return [];
         }
 

diff --git a/...kerSdkTest/Integrator/Filter/RatingBasedManifestFilter/RatingBasedManifestsFilterTest.php b/...kerSdkTest/Integrator/Filter/RatingBasedManifestFilter/RatingBasedManifestsFilterTest.php
@@ -27,7 +27,7 @@ public function testsFilterManifestsShouldReturnTheSameManifestsWhenRatingIsMax(
         //Arrange
         $manifests = $this->getManifests();
         $ratingBasedManifestsFilter = new RatingBasedManifestsFilter(
-            $this->createConfigurationProviderMock(RatingBasedManifestsFilter::MAX_RATING_THRESHOLD),
+            $this->createConfigurationProviderMock(RatingBasedManifestsFilter::MIN_RATING_THRESHOLD),
             $this->createModuleRatingFetcherMock(new ModulesRatingResponseDto([]), false),
             new ManifestToModulesRatingRequestMapper(),
         );
@@ -47,7 +47,7 @@ public function testsFilterManifestsShouldReturnEmptyManifestsWhenRatingIsMin():
         //Arrange
         $manifests = $this->getManifests();
         $ratingBasedManifestsFilter = new RatingBasedManifestsFilter(
-            $this->createConfigurationProviderMock(RatingBasedManifestsFilter::MIN_RATING_THRESHOLD),
+            $this->createConfigurationProviderMock(RatingBasedManifestsFilter::MAX_RATING_THRESHOLD + 1),
             $this->createModuleRatingFetcherMock(new ModulesRatingResponseDto([]), false),
             new ManifestToModulesRatingRequestMapper(),
         );