Skip to content

Commit

Permalink
SDK-2546: Fixed issue with cs & paths
Browse files Browse the repository at this point in the history
  • Loading branch information
vol4onok committed Aug 19, 2023
1 parent eddd31f commit 9343d22
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/Builder/ClassLoader/ClassLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public function loadClass(string $className): ClassInformationTransfer
$classInformationTransfer->setClassTokenTree($syntaxTree)
->setOriginalClassTokenTree($originalSyntaxTree)
->setTokens($this->lexer->getTokens())
->setFilePath($fileName);
->setFilePath(realpath($fileName));

Check failure on line 81 in src/Builder/ClassLoader/ClassLoader.php

View workflow job for this annotation

GitHub Actions / validation (7.4)

Parameter #1 $filePath of method SprykerSdk\Integrator\Transfer\ClassInformationTransfer::setFilePath() expects string|null, string|false given.

Check failure on line 81 in src/Builder/ClassLoader/ClassLoader.php

View workflow job for this annotation

GitHub Actions / validation (8.2)

Parameter #1 $filePath of method SprykerSdk\Integrator\Transfer\ClassInformationTransfer::setFilePath() expects string|null, string|false given.

Check failure on line 81 in src/Builder/ClassLoader/ClassLoader.php

View workflow job for this annotation

GitHub Actions / validation (7.4)

Parameter #1 $filePath of method SprykerSdk\Integrator\Transfer\ClassInformationTransfer::setFilePath() expects string|null, string|false given.

Check failure on line 81 in src/Builder/ClassLoader/ClassLoader.php

View workflow job for this annotation

GitHub Actions / validation (8.2)

Parameter #1 $filePath of method SprykerSdk\Integrator\Transfer\ClassInformationTransfer::setFilePath() expects string|null, string|false given.

$parentClass = $this->getParent($syntaxTree);
if ($parentClass) {
Expand Down
6 changes: 4 additions & 2 deletions src/Builder/FileNormalizer/PhpCSFixerFileNormalizer.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,11 @@ public function normalize(array $filePaths): void
$process = $this->processExecutor->execute($command);

// TODO remove when phpcbf will be able to fix all issues in file during the one iteration
if (defined('TEST_INTEGRATOR_MODE') && TEST_INTEGRATOR_MODE === 'true') {
\sleep(3);
if (defined('TEST_INTEGRATOR_MODE') && TEST_INTEGRATOR_MODE === 'true' && $process->getExitCode() !== 0) {
$process = $this->processExecutor->execute($command);
if ($process->getExitCode() !== 0) {
$process = $this->processExecutor->execute($command);
}
}

if ($process->getExitCode() > 0 && $process->getErrorOutput() !== '') {
Expand Down
5 changes: 1 addition & 4 deletions tests/SprykerSdkTest/Integrator/IntegratorFacadeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
use SprykerSdk\Integrator\Dependency\Console\InputOutputInterface;
use SprykerSdk\Integrator\Dependency\Console\SymfonyConsoleInputOutputAdapter;

/**
* @group test1
*/
class IntegratorFacadeTest extends AbstractIntegratorTestCase
{
/**
Expand Down Expand Up @@ -52,6 +49,7 @@ public function testRunInstallationConfigureModule(): void
}

/**
* @group test1
* @return void
*/
public function testRunInstallationWirePlugin(): void
Expand Down Expand Up @@ -121,7 +119,6 @@ public function testRunInstallationWireSchema(): void
}

/**
* @group test2
* @return void
*/
public function testRunInstallationUnwirePlugin(): void
Expand Down
Binary file removed tests/_data/archive.zip
Binary file not shown.

0 comments on commit 9343d22

Please sign in to comment.