Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-2896: Wrap to quotes glossary values #131

Merged
merged 5 commits into from
Aug 7, 2023
Merged

SDK-2896: Wrap to quotes glossary values #131

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d42302c
SDK-2896: Wrap to quotes glossary values
vol4onok Aug 4, 2023
533f14e
SDK-2896: Adjusted glossary strategy
vol4onok Aug 4, 2023
c1cd552
SDK-2896: Adjusted glossary strategy
vol4onok Aug 4, 2023
d251069
Merge remote-tracking branch 'origin/master' into bugfix/sdk-2896-glo…
DmytroKlymanSpryker Aug 7, 2023
d80138a
SDK-2896: Update manifests provider branch
DmytroKlymanSpryker Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/ManifestStrategy/GlossaryManifestStrategy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,21 @@ protected function createGlossaryFileLine(string $glossaryKey, string $glossaryK
{
return implode(',', [
$glossaryKey,
$glossaryKeyValue,
$this->wrapInQuotes($glossaryKeyValue),
$glossaryKeyLanguage,
]);
}

/**
* @param string $string
*
* @return string
*/
protected function wrapInQuotes(string $string): string
{
return strpos($string, ',') !== false ? sprintf('"%s"', $string) : $string;
}
DmytroKlymanSpryker marked this conversation as resolved.
Show resolved Hide resolved

/**
* @param array<array-key, string> $glossaryExistingFileLines
*
Expand Down
Loading