PR: Improve the way users can select the interface font in Preferences (Appearance) #22927

ccordoba12 · 2024-11-10T19:44:32Z

Description of Changes

This fixes a regression with respect to the same functionality in Spyder 5, introduced by PR: Add new combobox widgets (API) #21555.
Show a preview of the interface font that is updated automatically when users browse among the available fonts in the system (the last part is important in case users have too many fonts installed). I decided to follow @dalthviz's excellent suggestion in PR: Add new combobox widgets (API) #21555 (comment) about it.
Prevent font names to be elided in the combobox dropdown.
Automatically update the color scheme and monospace font shown in the editor preview widget when browsing them. This is to have feature parity with the new interface font preview.
Document API changes in our Changelog and add missing ones for 6.0.2

Visual changes

New interface font preview

Editor preview is automatically updated

Issue(s) Resolved

Fixes #22683

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

ccordoba12 · 2024-11-10T19:51:46Z

@dalthviz, please give this a manual check to see if the implementation works as expected for you.

Also, fix a small error in a comment.

Also, add a note about that in our Changelog along with the missing API changes done in 6.0.2

- This will give users the same kind of interactivity they get when checking different interface fonts in its preview widget. - Also, rename update_preview method to update_editor_preview for clarity.

dalthviz · 2024-11-11T22:38:04Z

Did a quick check and seems like the described functionality is working 👍 However, while checking this, I was able to trigger an error when changing the color scheme:

Traceback (most recent call last):
  File "E:\Acer\Documentos\Spyder\Spyder otros\carlos\spyder\spyder\plugins\appearance\confpage.py", line 507, in edit_scheme
    self.update_editor_preview(scheme_name='temp')
  File "E:\Acer\Documentos\Spyder\Spyder otros\carlos\spyder\spyder\plugins\appearance\confpage.py", line 414, in update_editor_preview
    scheme_name = self.scheme_choices_dict[scheme_name]
KeyError: 'temp'

Some other things I noticed which maybe could be improved or seems worthy to mention just in case:

Some of the fonts seems like are to big to be rendered a full preview?
Seems like the preview is only updated if moving the mouse over an item? So for example navigating with the keyboard doesn't do anything:

…ent scheme

ccordoba12 · 2024-11-13T17:38:20Z

Thanks for the review @dalthviz!

However, while checking this, I was able to trigger an error when changing the color scheme

I was able to reproduce this error and it should be fixed in my second to last commit.

Some of the fonts seems like are to big to be rendered a full preview?

Yeah, that also happens when you increase the interface font size to 15 or 20.

But the idea of the new preview widget is to give users a sense of how that font would look in the application. That's why I think we shouldn't change its size to accommodate the Happy Spydering! text. Doing that would also break the layout of the Appearance page.

Seems like the preview is only updated if moving the mouse over an item? So for example navigating with the keyboard doesn't do anything

Great catch! Fixed in my last commit.

…nged - Before we were not doing that when users selected a new item with the keyboard. - Also, fix entry in Changelog with missing class.

dalthviz

Thanks @ccordoba12 ! Gave this a manual check with the latest changes and seems like things are working as expected! Left a couple of comments/questions/ideas but no changes are actually that required for this to be merged so leaving approved 👍

Feel free to merge if you think is ready or let me know if you would like to do any further change following the comments I left

dalthviz · 2024-11-13T23:00:50Z

changelogs/Spyder-6.md

@@ -1,5 +1,16 @@
 # History of changes for Spyder 6

+## Version 6.0.3 (Unreleased)


As a follow up thing, maybe it could be worthy to add some instructions over the contributing guide mentioning that if an implementation/PR does API changes or any other change that should be featured over the changelog such change should be added as an entry over the CHANGELOG file as part of the changes the PR does?

dalthviz · 2024-11-13T23:05:09Z

spyder/api/widgets/comboboxes.py

+        if PYQT5 or PYQT6:
+            super().__init__(parent)
+        else:
+            QFontComboBox.__init__(self, parent)
+            _SpyderComboBoxMixin.__init__(self)


Maybe adding a reference on why this is needed for PySide 2/6 could be worthy

dalthviz · 2024-11-13T23:21:09Z

spyder/plugins/appearance/confpage.py

+        self.preview_editor.set_scrollpastend_enabled(False)
+
+        preview_interface_label = QLabel(_("Interface font"))
+        self.preview_interface = QLabel("Happy Spydering!")


Checking the QFontDialog seems like you are able to edit the text inside the preview widget for a font when using it:

I think it kind of make sense to allow users to edit the text since maybe they would like to check how other characters not visible in the preview default text could look. Also, since the preview for the monospace font can be edited, it also kind of makes sense for the other preview to be editable too, no? What do you think?

Also, although I kind of understand trying to be appealing by using the Happy Spydering! text, maybe a more standard text like the selected font's name or using a translatable text as Interface Font Sample or Sample or even AaBbYyZz could make sense? I'm fine with that text but sharing some alternatives just in case

ccordoba12 added type:Enhancement User Experience (UX) component:Main Window labels Nov 10, 2024

ccordoba12 added this to the v6.0.3 milestone Nov 10, 2024

ccordoba12 requested a review from dalthviz November 10, 2024 19:44

ccordoba12 self-assigned this Nov 10, 2024

ccordoba12 changed the title ~~PR: Improve the way can select the interface font in Preferences (Appearance)~~ PR: Improve the way users can select the interface font in Preferences (Appearance) Nov 10, 2024

ccordoba12 added 8 commits November 10, 2024 15:42

API: Avoid eliding text in SpyderFontComboBox items

0150135

API: Elide text of selected font in SpyderFontComboBox

4984dd5

Also, fix a small error in a comment.

API: Add a couple of new signals to our comboboxes

947e33e

Also, add a note about that in our Changelog along with the missing API changes done in 6.0.2

Appearance: Show a preview of the interface font in its config page

729a770

Appearance: Update editor preview when browsing its connected comboboxes

ac7921f

- This will give users the same kind of interactivity they get when checking different interface fonts in its preview widget. - Also, rename update_preview method to update_editor_preview for clarity.

App: Fix crash at startup with PySide2

eadbe47

API: Allow to change the items elide mode of our comboboxes

4c023c7

Appearance: Don't elide scheme names in the combobox that shows them

b0afba9

ccordoba12 force-pushed the issue-22683 branch from 94e2623 to b0afba9 Compare November 10, 2024 20:43

Appearance: Fix error when updating preview after changes to the curr…

59ecdc8

…ent scheme

API: Correctly report when the current item in our comboboxes has cha…

a7090c1

…nged - Before we were not doing that when users selected a new item with the keyboard. - Also, fix entry in Changelog with missing class.

ccordoba12 force-pushed the issue-22683 branch from aebfeeb to a7090c1 Compare November 13, 2024 17:49

dalthviz approved these changes Nov 13, 2024

View reviewed changes

ccordoba12 added component:Preferences and removed component:Main Window labels Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Improve the way users can select the interface font in Preferences (Appearance) #22927

PR: Improve the way users can select the interface font in Preferences (Appearance) #22927

ccordoba12 commented Nov 10, 2024 •

edited

Loading

ccordoba12 commented Nov 10, 2024 •

edited

Loading

dalthviz commented Nov 11, 2024

ccordoba12 commented Nov 13, 2024

dalthviz left a comment

dalthviz Nov 13, 2024

dalthviz Nov 13, 2024

dalthviz Nov 13, 2024

		@@ -1,5 +1,16 @@
		# History of changes for Spyder 6

		## Version 6.0.3 (Unreleased)

PR: Improve the way users can select the interface font in Preferences (Appearance) #22927

Are you sure you want to change the base?

PR: Improve the way users can select the interface font in Preferences (Appearance) #22927

Conversation

ccordoba12 commented Nov 10, 2024 • edited Loading

Description of Changes

Visual changes

Issue(s) Resolved

Affirmation

ccordoba12 commented Nov 10, 2024 • edited Loading

dalthviz commented Nov 11, 2024

ccordoba12 commented Nov 13, 2024

dalthviz left a comment

Choose a reason for hiding this comment

dalthviz Nov 13, 2024

Choose a reason for hiding this comment

dalthviz Nov 13, 2024

Choose a reason for hiding this comment

dalthviz Nov 13, 2024

Choose a reason for hiding this comment

ccordoba12 commented Nov 10, 2024 •

edited

Loading

ccordoba12 commented Nov 10, 2024 •

edited

Loading