Handle get params correctly (#10)

squake-earth · Oct 21, 2023 · d28547e · d28547e
1 parent 5ec35a9
commit d28547e
Show file tree

Hide file tree

Showing 16 changed files with 365 additions and 184 deletions.
diff --git a/lib/squake/util.rb b/lib/squake/util.rb
@@ -9,10 +9,15 @@ class Util
     # parameters in a URI or as form parameters in a request body. This mainly
     # involves escaping special characters from parameter keys and values (e.g.
     # `&`).
-    sig { params(params: T::Hash[Symbol, String]).returns(String) }
+    sig { params(params: T::Hash[Symbol, T.any(String, T::Array[String])]).returns(String) }
     def self.encode_parameters(params)
       params.map do |k, v|
-        "#{url_encode(k.to_s)}=#{url_encode(v.to_s)}" unless v.nil?
+        case v
+        when Array
+          v.map { |e| "#{url_encode(k.to_s)}[]=#{url_encode(e.to_s)}" }.join('&')
+        else
+          "#{url_encode(k.to_s)}=#{url_encode(v.to_s)}" unless v.nil?
+        end
       end.join('&')
     end
 

diff --git a/...ith_expand_argument/behaves_like_successful_pricing_response/returns_a_pricing_object.yml b/...ith_expand_argument/behaves_like_successful_pricing_response/returns_a_pricing_object.yml
diff --git a/...h_expand_argument/behaves_like_successful_pricing_response/returns_a_success_response.yml b/...h_expand_argument/behaves_like_successful_pricing_response/returns_a_success_response.yml
diff --git a/...tes/Squake_Pricing/_quote/when_requesting_with_expand_argument/returns_expanded_price.yml b/...tes/Squake_Pricing/_quote/when_requesting_with_expand_argument/returns_expanded_price.yml
diff --git a/...s/Squake_Pricing/_quote/when_requesting_with_expand_argument/returns_expanded_product.yml b/...s/Squake_Pricing/_quote/when_requesting_with_expand_argument/returns_expanded_product.yml
diff --git a/...ity/when_invalid_request/behaves_like_failed_pricing_response/does_not_contain_result.yml b/...ity/when_invalid_request/behaves_like_failed_pricing_response/does_not_contain_result.yml
diff --git a/...y/when_invalid_request/behaves_like_failed_pricing_response/returns_a_failed_response.yml b/...y/when_invalid_request/behaves_like_failed_pricing_response/returns_a_failed_response.yml