Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper project mapping for file changes in nested projects #16

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

pablobaxter
Copy link
Collaborator

In cases where there are nested projects, the parent project was being mapped for changes made in a child project. The logic previously returned the first project that mapped the changed file path, however it will now map to the last project mapped instead.

@pablobaxter pablobaxter changed the base branch from main to develop November 28, 2023 21:11
Copy link
Collaborator

@inez inez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a unit test for this.

@pablobaxter pablobaxter merged commit 75453d8 into develop Nov 28, 2023
1 check passed
@pablobaxter pablobaxter deleted the pb/fix-improper-mapping branch November 28, 2023 21:34
inez pushed a commit that referenced this pull request Mar 5, 2024
* Fix issue where parent project would be mapped for child project file changes.

* Add unit test for improper file mapping in nested projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants