This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Fix arduino backend timeout #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing ultrasound operations, the arduino may wait up to 1 second before sending a response. We need to ensure the timeout on a serial read is long enough to accomodate this. Separately, I've opened sourcebots/arduino-fw#28 to track possibly reducing the timeout in the firmware.
trickeydan
approved these changes
Aug 13, 2019
|
Code Climate has analyzed commit 2642cb5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 89.1% (0.0% change). View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing ultrasound operations, the arduino may wait up to
1 second before sending a response. We need to ensure the timeout
on a serial read is long enough to accomodate this.
Separately, I've opened sourcebots/arduino-fw#28
to track possibly reducing the timeout in the firmware.