Add NS1 DNS Scripts #817
Merged
Add NS1 DNS Scripts #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NS1 DNS scripts. I'm not affiliated with NS1, merely a free plan user.
API Doc: https://ns1.com/api?docId=2185
NS1 treats multiple records in the same RR type + subdomain + domain as a single API record, so when we add or delete a record, the API rejects further requests unless it is deleted. The way
dns_add_ns1works is that it deletes existing TXT records in_acme-challenge.example.com, and only then adds the new record.Ideally, the integration would merge existing record set and append the ACME challenge record. I just don't have enough
jqknow-how to do it. I think this is an OK compromise because it is unlikely that another ACME client deals with the same domain while getssl does its thing.