Comments please: #359
Open
Comments please: #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This toggles the setting to save tabs when you close patchbay. The setting is not yet enabled.
If the setting is enabled, then when we open a new tab, check if it is already in the list; if not add it.
If the save open tabs feature enabled, then if the page is in the opne tabs list, delete it from the list when closing the tab.
Based on the saved open tabs checkbox setting we will open on load all the tabs either from the default list or from save open tabs.
jedahan
reviewed
Oct 5, 2019
| const saveTabs = api.settings.obs.get('patchbay.saveTabs', false) | ||
| if (saveTabs()) { | ||
| const openTabs = api.settings.obs.get('patchbay.openTabs', []) | ||
| var _tabs = openTabs() |
There was a problem hiding this comment.
If using const, why not use let instead of var to be a tiny bit more strict regarding variable access?
There was a problem hiding this comment.
Thx... will do.
I "think" I can use api.settings.sync.get rather than obs.get too
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits provides a setting to save open tabs, o that when you close and reopen patchbay it retains the tabs you had open when you closed it.
Improvements, suggestions, mentoring on better approaches welcomed.