Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimization(validatorStore): handlers (add, remove, update) and tests #1946

Merged
merged 13 commits into from
Jan 13, 2025
Merged

optimization(validatorStore): handlers (add, remove, update) and tests #1946

merged 13 commits into from
Jan 13, 2025

Conversation

olegshmuelov
Copy link
Contributor

@olegshmuelov olegshmuelov commented Dec 17, 2024 •
edited
Loading

This PR optimizes the ValidatorStore by improving handler logic and enhancing the test suite for better efficiency, reliability, and coverage.

replacing #1716
potential fix #1926

@olegshmuelov olegshmuelov self-assigned this Dec 17, 2024
@olegshmuelov olegshmuelov changed the title optimization(validatorStore): handlers and tests optimization(validatorStore): handlers (add, remove, update) and tests Dec 17, 2024
@olegshmuelov olegshmuelov requested a review from y0sher December 18, 2024 16:24
@olegshmuelov olegshmuelov marked this pull request as ready for review December 18, 2024 17:04
y0sher
y0sher approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@y0sher y0sher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.05882% with 39 lines in your changes missing coverage. Please review.

Project coverage is 46.7%. Comparing base (7d19f37) to head (8be4d42).
Report is 2 commits behind head on stage.

Files with missing lines Patch % Lines
registry/storage/validatorstore.go 77.0% 29 Missing and 10 partials ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

moshe-blox
moshe-blox approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@moshe-blox moshe-blox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@olegshmuelov olegshmuelov requested a review from y0sher January 9, 2025 08:46
@olegshmuelov olegshmuelov merged commit 81c9e6b into stage Jan 13, 2025
7 checks passed
@olegshmuelov olegshmuelov deleted the optimization/validator-store-handling-tests branch January 13, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshe-blox moshe-blox moshe-blox approved these changes

@y0sher y0sher y0sher approved these changes

Assignees

@olegshmuelov olegshmuelov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olegshmuelov @y0sher @moshe-blox