Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiplatform build setup - linux/arm64 #113

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

kkulak
Copy link
Contributor

@kkulak kkulak commented Mar 22, 2024

Description

I couldn't run your operator on the EKS with ARM nodes, but I've managed to build the image locally with linux/armd64 target platform. I had to upgrade bitnami/kubectl:1.21.8 as well, because it was not supporting multiplatform builds: right now it does.

It's my first contribution to the project, so please check the changes carefully.

Is there any chance to get this reviewed, merged and released anytime soon? @gold-kou @R-HNF

Checklist

Please check if applicable

  • Tests have been added (if applicable, ie. when operator codes are added or modified)
  • Relevant docs have been added or modified (if applicable, ie. when new features are added or current features are modified)

Might be related to #74

Copy link
Contributor

@kane8n kane8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kane8n kane8n requested a review from a team March 26, 2024 08:01
Copy link
Contributor

@gold-kou gold-kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, I checked docker buildx works without error.

$ docker buildx create --use
$ docker run --privileged --rm tonistiigi/binfmt --install all
$ docker buildx build --platform linux/amd64,linux/arm64 -t hoge .

@kkulak
Copy link
Contributor Author

kkulak commented Mar 26, 2024

@kane8n @gold-kou thanks for the reviews! May I ask one of You to merge the PR and release the operator? I don't have the required permissions to do it on my own.

@kane8n kane8n merged commit 6a49574 into st-tech:main Mar 27, 2024
3 checks passed
@kane8n
Copy link
Contributor

kane8n commented Mar 27, 2024

@kkulak
Thanks for the PR, we released it as v0.9.5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants