-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Mobile screen rotation fix #1194
fix: Mobile screen rotation fix #1194
Conversation
…o the contributing docs
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (96.11%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
==========================================
+ Coverage 92.89% 93.20% +0.30%
==========================================
Files 42 42
Lines 4574 4662 +88
Branches 647 374 -273
==========================================
+ Hits 4249 4345 +96
+ Misses 318 315 -3
+ Partials 7 2 -5 ☔ View full report in Codecov by Sentry. |
The thought process behind the end designThe whole thing broke because I didnt check the mobile landscape mode 🙄, when I developed the more detailed session progress title text and didnt assume that someone moved everything around so dramatically. To fix this, I moved the progress text to the card context area, shrunk down the response buttons for small screens and only moved the upper control buttons to the left side in the landscape mode, such that more space is opened up for viewing the cards. I did my best to respect the wish to have more viewing space and at the same time to have a good and consistant design. PS.: The new contributing text is there so that no one repeats my mistakes 😅 |
… the chosen deck, if it is only one deck
…just like the bold text
@KyleKlus Thanks for fixing this. Works for me on iPad and Desktop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KyleKlus, thanks for the fix!
My only question is, can we make the card context always appear on a separate line on its own? Something like this:
Currently, it moves to the bottom when the card context is too long which is a bit distracting if it keeps switching places:
Sure, let's do that 😊. I'll work on it either this evening or tomorrow, so it should be ready until Tuesday. |
This reverts commit 5e84528.
This reverts commit 6486c10.
Change Decks list card count box size Changed the minimum width of the boxes, that there will fit for numbers up to 9999. Currently there only will fit if the numbers are below 999 what in my case and certainly for others too is not enough.
* Update tr.ts Türkçe yeni çeviriler eklendi ve bazıları güncellendi. * Update tr.ts * Update tr.ts düzeltmeler ve güncelemeler yapıldı
This reverts commit 5e84528.
This reverts commit 6486c10.
…lus/obsidian-spaced-repetition into mobile-screen-rotation-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the UI fixes!
This pr fixes the current visual bug, when the plugin is used on a mobile device in landscape mode (See pictures).
Further more this pr also adds a "how to develop & test ui changes" to the contribution page, so that these issues wont arise again in a future ui change.
PC design
For reference: Old design used on a pc
New design used on a pc
Mobile design
For reference: Old design on a mobile device in landscape mode with the visual bug
New design on a mobile device in landscape mode
Old design on a small mobile device in landscape mode with visual bug
New design on a small mobile device in landscape mode
New contributing text