Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Static method findAndReplace leads to failure if the lineNo is 0 instead of null #828 #830

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[BUG] Static method findAndReplace leads to failure if the lineNo is 0 instead of null #828 #830

merged 1 commit into from
Jan 15, 2024

Conversation

michail-sygk
Copy link
Contributor

@michail-sygk michail-sygk commented Jan 6, 2024 •
edited
Loading

Fixes #828

@michail-sygk michail-sygk changed the title fix:multiLineTextFinder to handle null return value from find method [BUG] Static method findAndReplace leads to failure if the lineNo is 0 instead of null #828 Jan 6, 2024
@michail-sygk michail-sygk mentioned this pull request Jan 8, 2024
Closed
@biocarl biocarl mentioned this pull request Jan 12, 2024
Closed
@biocarl
Copy link

biocarl commented Jan 12, 2024

Also fixes my issue and looks fine for me 👍

st3v3nmw
st3v3nmw approved these changes Jan 15, 2024
View reviewed changes
Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michail-sygk,

Thanks for the bug fix!

@st3v3nmw st3v3nmw merged commit 9b81cdf into st3v3nmw:master Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3v3nmw st3v3nmw st3v3nmw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Static method findAndReplace leads to failure if the lineNo is 0 instead of null
3 participants
@michail-sygk @biocarl @st3v3nmw