-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix email page suspense issue #406
base: dev
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Documentation Changes Required
|
<Suspense> | ||
<PageLayout> | ||
<EmailsSection/> | ||
{passwordSection} | ||
{passkeySection} | ||
{otpSection} | ||
{mfaSection} | ||
</PageLayout> | ||
</Suspense> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the very least, every suspense should have a fallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a loader/skeleton component that you want as a fallback?
Important
Add
Suspense
to handle loading states inEmailsAndAuthPage
andAccountSettings
.EmailsAndAuthPage
inSuspense
inAccountSettings
to handle loading states.PageLayout
inSuspense
inEmailsAndAuthPage
to handle loading states.This description was created by for d0f4c53. It will automatically update as commits are pushed.