Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake : sync submodule + fix MathJax relpath, remove DOXYGEN_USE_TEMPLATE_CSS, remove MATHJAX_FORMAT spec #2558

Conversation

ManifoldFR
Copy link
Member

@ManifoldFR ManifoldFR commented Jan 24, 2025

This PR follows the following two PRs on jrl-cmakemodules:

Local changes on Pinocchio include:

  • removing the DOXYGEN_USE_TEMPLATE_CSS option which is irrelevant (removed in the first cmakemodules PR)
  • removing the empty spec for MATHJAX_RELPATH which was wrong and broke the math

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@ManifoldFR ManifoldFR force-pushed the topic/cmake-sync-submodule-and-mathjax branch from d63ab99 to 360de97 Compare January 24, 2025 16:50
Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. Thanks a lot @ManifoldFR

@jcarpent jcarpent enabled auto-merge January 24, 2025 16:53
@ManifoldFR
Copy link
Member Author

is the ROS-industrial CI still broken? 🤣

@jcarpent
Copy link
Contributor

is the ROS-industrial CI still broken? 🤣

Yes.

@jcarpent jcarpent merged commit f07996c into stack-of-tasks:devel Jan 24, 2025
22 of 26 checks passed
@ManifoldFR ManifoldFR deleted the topic/cmake-sync-submodule-and-mathjax branch January 24, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants