Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support configuring JVM arguments #636

Merged
merged 14 commits into from
Jan 29, 2025
Merged

feat: Support configuring JVM arguments #636

merged 14 commits into from
Jan 29, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Dec 27, 2024

Description

Part of stackabletech/issues#584

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer
Copy link
Member Author

@sbernauer sbernauer marked this pull request as ready for review January 28, 2025 14:12
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things, LGTM otherwise.

CHANGELOG.md Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
rust/operator-binary/src/config/jvm.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/config/jvm.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/config/jvm.rs Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

@sbernauer sbernauer requested a review from maltesander January 28, 2025 15:55
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if test passes!

@sbernauer
Copy link
Member Author

Tests passed 🚀

@sbernauer sbernauer added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 7b9a2a4 Jan 29, 2025
17 checks passed
@sbernauer sbernauer deleted the feat/jvm-args branch January 29, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants