Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add oci references, merge templating changes #640

Merged
merged 7 commits into from
Jan 30, 2025
Merged

chore: add oci references, merge templating changes #640

merged 7 commits into from
Jan 30, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Jan 17, 2025 •
edited by adwk67
Loading

Description

  • merge templating PR
  • change all references, use search-and-replace to find things (Makefile, Dockerfiles, operator Helm Charts, default,nix, kuttl tests, ....)
  • ensure that kuttl tests are running
  • for every image reference, ensure that the image is actually in Harbor (and image hash is the same as before?)
--- PASS: kuttl (5763.06s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-default_listener-class-external-unstable_openshift-false (199.27s)
        --- PASS: kuttl/harness/topology-provider_hadoop-latest-3.4.0_zookeeper-latest-3.9.2_krb5-1.21.1_kerberos-backend-mit_openshift-false (323.54s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.4_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (145.42s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-default_listener-class-cluster-internal_openshift-false (95.83s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (102.80s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (105.73s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.4_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-default_listener-class-external-unstable_openshift-false (131.60s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.4_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-default_listener-class-cluster-internal_openshift-false (123.58s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.4_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (152.96s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.4_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-default_listener-class-external-unstable_openshift-false (98.88s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.4_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-default_listener-class-cluster-internal_openshift-false (116.30s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (156.06s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.4_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (496.68s)
        --- PASS: kuttl/harness/profiling_hadoop-3.4.0_zookeeper-latest-3.9.2_openshift-false (124.85s)
        --- PASS: kuttl/harness/profiling_hadoop-3.3.6_zookeeper-latest-3.9.2_openshift-false (130.67s)
        --- PASS: kuttl/harness/profiling_hadoop-3.3.4_zookeeper-latest-3.9.2_openshift-false (117.59s)
        --- PASS: kuttl/harness/logging_hadoop-3.4.0_zookeeper-latest-3.9.2_openshift-false (439.86s)
        --- PASS: kuttl/harness/logging_hadoop-3.3.6_zookeeper-latest-3.9.2_openshift-false (432.12s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-default_listener-class-external-unstable_openshift-false (148.89s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-default_listener-class-cluster-internal_openshift-false (151.97s)
        --- PASS: kuttl/harness/logging_hadoop-3.3.4_zookeeper-latest-3.9.2_openshift-false (395.47s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (110.23s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (483.40s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-default_listener-class-external-unstable_openshift-false (122.91s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.4_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (121.90s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-default_listener-class-cluster-internal_openshift-false (108.35s)
        --- PASS: kuttl/harness/kerberos_hadoop-3.3.6_zookeeper-latest-3.9.2_krb5-1.21.1_opa-0.67.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_openshift-false (859.46s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (109.22s)
        --- PASS: kuttl/harness/kerberos_hadoop-3.3.4_zookeeper-latest-3.9.2_krb5-1.21.1_opa-0.67.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_openshift-false (814.14s)
        --- PASS: kuttl/harness/kerberos_hadoop-3.3.4_zookeeper-latest-3.9.2_krb5-1.21.1_opa-0.67.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_openshift-false (846.87s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-default_listener-class-cluster-internal_openshift-false (139.50s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-default_listener-class-external-unstable_openshift-false (156.40s)
        --- PASS: kuttl/harness/kerberos_hadoop-3.4.0_zookeeper-latest-3.9.2_krb5-1.21.1_opa-0.67.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_openshift-false (800.71s)
        --- PASS: kuttl/harness/kerberos_hadoop-3.3.6_zookeeper-latest-3.9.2_krb5-1.21.1_opa-0.67.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_openshift-false (812.25s)
        --- PASS: kuttl/harness/cluster-operation_hadoop-latest-3.4.0_zookeeper-latest-3.9.2_openshift-false (141.83s)
        --- PASS: kuttl/harness/orphaned-resources_hadoop-latest-3.4.0_zookeeper-latest-3.9.2_openshift-false (101.64s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (498.09s)
        --- PASS: kuttl/harness/kerberos_hadoop-3.4.0_zookeeper-latest-3.9.2_krb5-1.21.1_opa-0.67.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_openshift-false (847.70s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (157.57s)
PASS

Openshift:

--- PASS: kuttl (2193.48s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/orphaned-resources_hadoop-latest-3.4.0_zookeeper-latest-3.9.2_openshift-true (288.49s)
        --- PASS: kuttl/harness/cluster-operation_hadoop-latest-3.4.0_zookeeper-latest-3.9.2_openshift-true (246.73s)
        --- PASS: kuttl/harness/logging_hadoop-3.4.0_zookeeper-latest-3.9.2_openshift-true (740.37s)
        --- PASS: kuttl/harness/topology-provider_hadoop-latest-3.4.0_zookeeper-latest-3.9.2_krb5-1.21.1_kerberos-backend-mit_openshift-true (302.72s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-true (210.18s)
        --- PASS: kuttl/harness/profiling_hadoop-3.4.0_zookeeper-latest-3.9.2_openshift-true (200.11s)
        --- PASS: kuttl/harness/kerberos_hadoop-3.4.0_zookeeper-latest-3.9.2_krb5-1.21.1_opa-0.67.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_openshift-true (1242.66s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@xeniape xeniape self-assigned this Jan 17, 2025
@xeniape xeniape marked this pull request as ready for review January 30, 2025 07:34
@xeniape xeniape requested a review from adwk67 January 30, 2025 07:35
adwk67
adwk67 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 3c2c254 Jan 30, 2025
17 checks passed
@xeniape xeniape deleted the chore/switch-to-oci-repo branch January 30, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@xeniape xeniape

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xeniape @adwk67