Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Add configuration options for the secret migration job #536

Merged
merged 2 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,15 @@ All notable changes to this project will be documented in this file.

- Made RSA key length configurable for certificates issued by cert-manager ([#528]).

### Fixed

- Helm chart: The secret migration job can be omitted via Helm values ([#536]).
- Helm chart: The tag of the tools image used for the secret migration job can
be changed in the Helm values and defaults now to 1.0.0-stackable24.11.0
rather than being hard-coded to 1.0.0-stackable24.7.0 ([#536]).

[#528]: https://github.com/stackabletech/secret-operator/pull/528
[#536]: https://github.com/stackabletech/secret-operator/pull/536

## [24.11.0] - 2024-11-18

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
{{ if .Values.secretMigrationJob.enabled -}}
# Migrates the TLS CA key pair from the hard-coded default namespace to the operator namespace
# See https://github.com/stackabletech/secret-operator/issues/453
apiVersion: batch/v1
Expand Down Expand Up @@ -30,7 +31,7 @@ spec:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
containers:
- name: migrate-secret
image: "{{ .Values.secretMigrationJob.image.repository }}:1.0.0-stackable24.7.0"
image: "{{ .Values.secretMigrationJob.image.repository }}:{{ .Values.secretMigrationJob.image.tag }}"
imagePullPolicy: {{ .Values.secretMigrationJob.image.pullPolicy }}
resources:
{{ .Values.secretMigrationJob.resources | toYaml | nindent 12 }}
Expand All @@ -53,3 +54,4 @@ spec:
fi
fi
restartPolicy: Never
{{- end }}
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
{{ if .Values.secretMigrationJob.enabled -}}
apiVersion: v1
kind: ServiceAccount
metadata:
Expand Down Expand Up @@ -53,4 +54,5 @@ rules:
- watch
- create
- patch
- update
- update
{{- end }}
2 changes: 2 additions & 0 deletions deploy/helm/secret-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ image:
pullSecrets: []

secretMigrationJob:
enabled: true
image:
repository: docker.stackable.tech/stackable/tools
tag: 1.0.0-stackable24.11.0
siegfriedweber marked this conversation as resolved.
Show resolved Hide resolved
pullPolicy: IfNotPresent
resources:
requests:
Expand Down
Loading