-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: olm deployment helper #546
base: main
Are you sure you want to change the base?
Conversation
This reverts commit acee691.
nginx-deployment.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an accidental left-over?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review. Will try to give it a proper look tomorrow.
x @ serde_json::Value::Null => { | ||
*x = serde_json::json!({}); | ||
x.as_object_mut().unwrap() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use expect
instead of unwrap, and then write the expectation as the fist argument.
x @ serde_json::Value::Null => { | |
*x = serde_json::json!({}); | |
x.as_object_mut().unwrap() | |
} | |
x @ serde_json::Value::Null => { | |
*x = serde_json::json!({}); | |
x.as_object_mut().expect("the empty object above is guaranteed to result in Some(serde_json::Map)") | |
} |
🟢 Tested on Openshift:
|
Install the secret operator using OLM and the `olm-deployer`. From the `stackable-utils` repo, run: | ||
|
||
```bash | ||
$ ./olm/build-bundles.sh -c $HOME/repo/stackable/openshift-certified-operators -r 24.11.0 -o secret -d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we are now pushing to OCI, it is necessary to login first with:
docker login oci.stackable.tech
and then supply username plus a CLI key obtained from User/Profile in the Harbor UI
Description
Part of: stackabletech/issues#666
This PR adds a new binary crate (
olm-deployer
) to the secret operator.The binary is bundled in the resulting container image and is only used by the OLM.
How to test
Requirements:
secret-olm-deployer
from the operators repo.stackable-utils
repoInstall the secret operator using OLM and the
olm-deployer
. From thestackable-utils
repo, run:The secret op and all it's dependencies should be installed and running in the
stackable-operators
namespace.Note
The ClusterSertviceVersion is now using the olm-deployer binary instead of the shell script
This is the relevant part of the
clusterservicedefinition.yaml
file:Integration tests
First checkout
release-24.11
branch of the secret operator repo. This is needed becausesecret-olm-deployer
branch deploys the 24.11.0 op version. The fact that 24.11.1 is now latest doesn't matter.