-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rectangular customizable spotlight, fading animation, touchable backdrop #54
base: main
Are you sure you want to change the base?
Conversation
…p (rectangle / circle)
…he rectangle shape
Hi @Enneson, sorry for the delayed response! Thanks a lot for your contribution, I'll be reviewing the changes in the following days and try to post some status updates along the way 🙂 |
@Enneson, sorry for the late review. I think there are great features in this PR, but unfortunately, I passed the changes through the example in the repo and it seems they are breaking the spotlight sizing (see the attached video). My first thought is that the issue may be caused by the changes in the styles of the I think the Cheers! spotlight-example-pr54.mov |
@JoseLion Hey, I guess the issue is also live in the package any updates on this one? |
The issue should be solved now on version v2.0.0. We had to go over a refactor on the animation flow, so it might be hard to reconcile this PR with |
Premise
The library is good in general. During the tests, our team didn't encounter any issues. It works great and looks clean from the code perspective as well. Great work!
Unfortunately, it doesn't cover all requirements of our project at the moment. That's why we decided to improve this library by adding alternatives for the highlighted area and animation, a touchable backdrop, Native Driver for Android, etc.
Status
Stable. A review will be appreciated.
Changes