Add image platform argument #53
Conversation
MaxBed4d
force-pushed
the
aarch64-image-build
branch
from
082b26b to
1a478b6
Compare
roles/os_images/tasks/images.yml
Outdated
| %}-p {{ item.packages | join(',') }}{% endif %} {{ os_images_common }} {{ item.elements | join(' ') }} -o {{ item.name }} | ||
| {% if item.size is defined %}--image-size {{ item.size }}{% endif %} {% if item.type is defined %}-t {{ item.type }}{% endif %} | ||
| {% if item.packages | default %}-p {{ item.packages | join(',') }}{% endif %} {{ os_images_common }} {{ item.elements | join(' ') }} | ||
| -o {{ item.name }} -a {{ os_images_architecture }} |
There was a problem hiding this comment.
Can we set a default value for os_images_architecture? Otherwise I think this will break existing usage of the role as no one will have defined this yet.
There was a problem hiding this comment.
Maybe it could be set based on the target host's arch?
There was a problem hiding this comment.
Defaults have been set in both Kayobe and SKC.
https://review.opendev.org/c/openstack/kayobe/+/940894/1/ansible/overcloud-host-image-build.yml
There was a problem hiding this comment.
This role can be used outside of Kayobe though :)
There was a problem hiding this comment.
We probably want architecture as part of os_images_list right?
That would make this something like:
{% if item.architecture | default %}-a {{ item.architecture }}{% endif %}
This wouldn't need a kayobe change then, just one in kayobe-config to add architecture as an element in overcloud_dib_host_images
There was a problem hiding this comment.
All the variables in this task are directly derived from the disk image builder variables in Kayobe so if trying to use it without the role from Kayobe they would be encountering other issues of the exact same nature, which would only work when they have defined the variables. But I see your point and we could add another default, but this should also be reflected for other vars too
There was a problem hiding this comment.
(accidentally deleted my comment) Discussed with @MaxBed4d, we should account for this existing option too:
Co-authored-by: Matt Crees <[email protected]>
Done, added to the README.md |
MaxBed4d
force-pushed
the
aarch64-image-build
branch
from
97dff41 to
c579189
Compare
MaxBed4d
force-pushed
the
aarch64-image-build
branch
from
c579189 to
31ad1be
Compare
No description provided.