-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCA workflow support #1469
DOCA workflow support #1469
Conversation
@assumptionsandg is this ready for review? |
f87435a
to
ed2ad6d
Compare
ed2ad6d
to
f66506c
Compare
3aa21d9
to
931e82c
Compare
The client side of this works, have tested in a prod system 👍 |
Co-authored-by: Alex-Welsh <[email protected]>
Co-authored-by: Alex-Welsh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last little comments. I think we should be able to get this merged today
Co-authored-by: Matt Anson <[email protected]>
4d2a820
to
97ebc43
Compare
97ebc43
to
abb14a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just be sure to squash when you merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on client staging system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hypervisor crashes have been observed with this setup on a prod system, lets hold off on merging for now
We've been able to recreate the crashes with the inbox driver, so it seems to be an issue with SRIOV+RL9.5 at this specific site. So imo this doesn't need to block this PR anymore. |
Latest configuration tested at UKHSA:
https://github.com/stackhpc/ukhsa-kayobe-config/commits/ukhsa-doca-deploy2