Use protobuf reflection for loading runtime configuration #2025
+942
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is based upon a toy project I have at https://github.com/Molter73/config-much. The basic idea is to use the reflection API from protobuf to populate the runtime configuration structures, which should allow us to add new fields to our protobuf definitions and have them magically show up in our code to use.
Stringy
reviewed
Feb 10, 2025
collector/lib/ConfigLoader.cpp
Outdated
Comment on lines
380
to
400
| case FieldDescriptor::CPPTYPE_INT32: | ||
| return ParseArrayInner<int32>(msg, node, field); | ||
| case FieldDescriptor::CPPTYPE_UINT32: | ||
| return ParseArrayInner<uint32_t>(msg, node, field); | ||
| case google::protobuf::FieldDescriptor::CPPTYPE_INT64: | ||
| return ParseArrayInner<int64_t>(msg, node, field); | ||
| case google::protobuf::FieldDescriptor::CPPTYPE_UINT64: | ||
| return ParseArrayInner<uint64_t>(msg, node, field); | ||
| case google::protobuf::FieldDescriptor::CPPTYPE_DOUBLE: | ||
| return ParseArrayInner<double>(msg, node, field); | ||
| case google::protobuf::FieldDescriptor::CPPTYPE_FLOAT: | ||
| return ParseArrayInner<float>(msg, node, field); | ||
| case google::protobuf::FieldDescriptor::CPPTYPE_BOOL: | ||
| return ParseArrayInner<bool>(msg, node, field); | ||
| case google::protobuf::FieldDescriptor::CPPTYPE_ENUM: | ||
| return ParseArrayEnum(msg, node, field); | ||
| case google::protobuf::FieldDescriptor::CPPTYPE_STRING: | ||
| return ParseArrayInner<std::string>(msg, node, field); | ||
| case google::protobuf::FieldDescriptor::CPPTYPE_MESSAGE: { | ||
| return {{"Unsupport repeated type MESSAGE"}}; | ||
| } break; |
There was a problem hiding this comment.
[nit]
Suggested change
| case FieldDescriptor::CPPTYPE_INT32: | |
| return ParseArrayInner<int32>(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_UINT32: | |
| return ParseArrayInner<uint32_t>(msg, node, field); | |
| case google::protobuf::FieldDescriptor::CPPTYPE_INT64: | |
| return ParseArrayInner<int64_t>(msg, node, field); | |
| case google::protobuf::FieldDescriptor::CPPTYPE_UINT64: | |
| return ParseArrayInner<uint64_t>(msg, node, field); | |
| case google::protobuf::FieldDescriptor::CPPTYPE_DOUBLE: | |
| return ParseArrayInner<double>(msg, node, field); | |
| case google::protobuf::FieldDescriptor::CPPTYPE_FLOAT: | |
| return ParseArrayInner<float>(msg, node, field); | |
| case google::protobuf::FieldDescriptor::CPPTYPE_BOOL: | |
| return ParseArrayInner<bool>(msg, node, field); | |
| case google::protobuf::FieldDescriptor::CPPTYPE_ENUM: | |
| return ParseArrayEnum(msg, node, field); | |
| case google::protobuf::FieldDescriptor::CPPTYPE_STRING: | |
| return ParseArrayInner<std::string>(msg, node, field); | |
| case google::protobuf::FieldDescriptor::CPPTYPE_MESSAGE: { | |
| return {{"Unsupport repeated type MESSAGE"}}; | |
| } break; | |
| case FieldDescriptor::CPPTYPE_INT32: | |
| return ParseArrayInner<int32>(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_UINT32: | |
| return ParseArrayInner<uint32_t>(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_INT64: | |
| return ParseArrayInner<int64_t>(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_UINT64: | |
| return ParseArrayInner<uint64_t>(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_DOUBLE: | |
| return ParseArrayInner<double>(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_FLOAT: | |
| return ParseArrayInner<float>(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_BOOL: | |
| return ParseArrayInner<bool>(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_ENUM: | |
| return ParseArrayEnum(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_STRING: | |
| return ParseArrayInner<std::string>(msg, node, field); | |
| case FieldDescriptor::CPPTYPE_MESSAGE: { | |
| return {{"Unsupport repeated type MESSAGE"}}; | |
| } break; |
There was a problem hiding this comment.
I'm also going to space them out a bit, it's a little hard to read otherwise.
collector/lib/ConfigLoader.cpp
Outdated
| } | ||
|
|
||
| config_.SetRuntimeConfig(std::move(runtime_config)); | ||
| CLOG(DEBUG) << "Runtime configuration:\n" |
There was a problem hiding this comment.
Can we set this to INFO? I don't think it should trigger often enough to be spamming the log, and would be invaluable to see how Collector is operating at any given moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is based upon a toy project I have at https://github.com/Molter73/config-much.
The basic idea is to use the introspection and reflection APIs from protobuf to populate the runtime configuration structures, which should allow us to add new fields to our protobuf definitions and have them magically show up in our code to use.
This is an alternative implementation to #1993.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI should be enough to ensure no behavioral changes have been introduced.