Initial implementation. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Looks good for the first step. I briefly looked at deployment.yaml maybe someone with more experience can verify it.
I think we need CI for this + linter (https://github.com/marketplace/actions/run-golangci-lint)
janisz
reviewed
Apr 18, 2024
Co-authored-by: Tomasz Janiszewski <[email protected]>
|
@rukletsov would you be able to review this while @janisz is out? |
janisz
approved these changes
Apr 23, 2024
jdao-rh
added a commit
that referenced
this pull request
Nov 5, 2024
Have a metadata generation task per arch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a bare-bones (no metric gathering support) but functional implementation.
Tested in stackrox/stackrox#10750
On that PR, (judging from the logs of a few jobs) deploying the pre-fetcher added 7-18 seconds, and waiting for pulls to complete 1-4 seconds to the job runtime, but likely provided a moderate net speed-up, since non-prefetched stackrox image pulls was on the order of 20-40 seconds.