Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KO Classic Phonemizers + BaseKoreanPhonemizer] Improve KO romanization + phonetic hint fix + typo fix #1399

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[KO Classic Phonemizers + BaseKoreanPhonemizer] Improve KO romanization + phonetic hint fix + typo fix #1399

wants to merge 3 commits into from

Conversation

lottev1991
Copy link
Contributor

@lottev1991 lottev1991 commented Jan 30, 2025 •
edited
Loading

  • Fixed phonetic hint functionality in the Korean VCV phonemizer. This function got broken a while ago due to some unnecessary lines of code.
  • Improved romanization in the Korean VCV Phonemizer. Now it works together with vowel endings, mixed Hangul/romanized notes, and with phonetic hint notes. Before, it only worked together with other romanized notes.
  • I added the same functionality to the Korean to Japanese Phonemizer. Now you won't need to type Hangul anymore if you're unable to.
  • Fixed some typos in the Base Korean Phonemizer API.
  • Implement MsToTickAt() in the Korean to Japanese Phonemizer.

@lottev1991
Copy link
Contributor Author

It seems I am getting errors related to .NET 8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lottev1991