-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stansummary to use split, rank-normalized Rhat, ESS #1301
Conversation
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
love the template solution which allows chains and chainset objects. how much work would be required for the following 2 things:
|
I’d prefer to keep any further behavior changes in a separate PR. Copying over the tests seems easy, though |
on further consideration, comments re what console output should look like is an extremely low-priority issue, since the CSV files are the most-used (by CmdStanPy) output from this utility - so low-priority as to not be worth the effort. |
Also fix CSV precision bug in matrix outputs
New tests added -- one of them caught an existing issue where matrix outputs would have a different behavior with respect to |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Huh, it appears our formatting logic does not consistently select between scientific notation and normal floating point representation between two different machines. That makes the test which checks against exact outputs impossible, so I've simplified Probably worth investigating another time, though as you note, the console output is not the 'primary' product here. Edit: I ended up backing out those tests entirely. Because this PR doesn't touch the formatting behavior, I'd rather not have to in order to add the new tests |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
many many thanks for this!
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
Based on #1290, but tries to touch less of the code. This updates
stansummary_helper
to usechainset
instead ofchains
, and updates the existing tests to match.Ditto for
diagnose
, but there I just took the code whole-cloth from @mitzimorris' PRIntended Effect:
Closes #1263 by adding the new metrics to stansummary
How to Verify:
Side Effects:
Stansummary no longer shows an ESS/s metric.
Documentation:
Will update https://mc-stan.org/docs/cmdstan-guide/stansummary.html if merged
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Simons foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: