Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tibble::num #263

Merged
merged 5 commits into from
Dec 28, 2022
Merged

support tibble::num #263

merged 5 commits into from
Dec 28, 2022

Conversation

paul-buerkner
Copy link
Collaborator

This PR implements support for tibble::num in summarise_draws (issue #257).

@avehtari can you check this out and tell me if that looks reasonable to you?

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #263 (e54cb73) into master (ef688e3) will decrease coverage by 0.80%.
The diff coverage is 100.00%.

❗ Current head e54cb73 differs from pull request most recent head dd975b5. Consider uploading reports for the commit dd975b5 to get more accurate results

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   95.86%   95.06%   -0.81%     
==========================================
  Files          44       42       -2     
  Lines        3340     2938     -402     
==========================================
- Hits         3202     2793     -409     
- Misses        138      145       +7     
Impacted Files Coverage Δ
R/summarise_draws.R 81.75% <100.00%> (+0.40%) ⬆️
R/rvar-cast.R 91.76% <0.00%> (-7.11%) ⬇️
R/as_draws_array.R 95.00% <0.00%> (-5.00%) ⬇️
R/as_draws.R 85.00% <0.00%> (-2.50%) ⬇️
R/rvar-summaries-over-draws.R 93.93% <0.00%> (-2.07%) ⬇️
R/draws-index.R 93.36% <0.00%> (-0.52%) ⬇️
R/rvar-.R 96.70% <0.00%> (-0.46%) ⬇️
R/rvar-bind.R 98.55% <0.00%> (-0.19%) ⬇️
R/as_draws_df.R 98.92% <0.00%> (-0.10%) ⬇️
R/as_draws_matrix.R 97.67% <0.00%> (-0.08%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paul-buerkner. Code looks good to me!

@avehtari
Copy link
Collaborator

avehtari commented Dec 2, 2022

It's likely that I don't have time to check this until 13th December

@avehtari
Copy link
Collaborator

Looks good. When testing, I really liked summary(.num_args=list(sigfig=2,notation="dec")) (so much faster to read the summary of many rows and columns). Would it be possible to have an option, so that I can set these as my defaults? I couldn't find this in tibble/num documentation

@paul-buerkner
Copy link
Collaborator Author

I have now added the global posterior.num_args option to control this printing behavior. Once all the checks are completed, I will merge this PR.

@paul-buerkner paul-buerkner merged commit 7e62efe into master Dec 28, 2022
@avehtari
Copy link
Collaborator

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants