Changed Linear to rename In and Out to avoid conflicting names (fixes #53) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooljoseph1
changed the title
cooljoseph1
changed the title
|
fixes #53 |
|
thanks for doing this. I kind of think the way it was originally specced is the correct way, b/c of sharding, but I'm willing to be convinced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a pretty small pull request. The only changes are to
src/haliax/nn/linear.pyand an added test attests/test_nn.py.The change in
linear.pyis to make Linear rename the In axis name(s) to end in "_in" and the Out axis name(s) to end in "_out" when creating the weight/bias tensors. When Linear is called, it now renames the inputs and outputs accordingly.The added test in
test_nn.pymakes sure that a Linear module can be created with conflicting axes' names in In and Out.