Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fetchmany #341

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Implement fetchmany #341

merged 1 commit into from
Aug 9, 2023

Conversation

damian3031
Copy link
Member

Implement missing fetchmany method in ConnectionWrapper.
Add tests for it.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Comment on lines +98 to +101
([], 5), # default limit
(["--limit", 3], 3), # fetch 3 rows
(["--limit", -1], 7), # fetch all rows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that this test is used for fetchmany testing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@damian3031 damian3031 merged commit 9387fe7 into master Aug 9, 2023
9 of 10 checks passed
@damian3031 damian3031 deleted the implement-fetchmany branch August 9, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants