-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(starknet_os): split Hint to OsHint and syscall + test syscall eq…
…uivalence with blockifier
- Loading branch information
Showing
2 changed files
with
115 additions
and
92 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,43 @@ | ||
| use std::collections::HashSet; | ||
|
|
||
| use blockifier::execution::hint_code::SYSCALL_HINTS; | ||
| use strum::IntoEnumIterator; | ||
|
|
||
| use super::{Hint, HintExtension}; | ||
| use super::{HintExtension, OsHint, SyscallHint}; | ||
| use crate::hints::types::HintEnum; | ||
|
|
||
| #[test] | ||
| fn test_hint_strings_are_unique() { | ||
| let hint_strings = Hint::iter().map(|hint| hint.to_str()).collect::<Vec<_>>(); | ||
| let hint_strings = OsHint::iter().map(|hint| hint.to_str()).collect::<Vec<_>>(); | ||
| let hint_extension_strings = | ||
| HintExtension::iter().map(|hint| hint.to_str()).collect::<Vec<_>>(); | ||
| let syscall_hint_strings = OsHint::iter().map(|hint| hint.to_str()).collect::<Vec<_>>(); | ||
| let hint_strings_set: HashSet<&&str> = HashSet::from_iter(hint_strings.iter()); | ||
| let hint_extension_strings_set = HashSet::from_iter(hint_extension_strings.iter()); | ||
| let syscall_hint_strings_set: HashSet<&&str> = HashSet::from_iter(syscall_hint_strings.iter()); | ||
| assert_eq!(hint_strings.len(), hint_strings_set.len(), "Duplicate hint strings."); | ||
| assert_eq!( | ||
| hint_extension_strings.len(), | ||
| hint_extension_strings_set.len(), | ||
| "Duplicate hint extension strings." | ||
| ); | ||
| let ambiguous_strings = | ||
| hint_strings_set.intersection(&hint_extension_strings_set).collect::<Vec<_>>(); | ||
| assert!(ambiguous_strings.is_empty(), "Ambiguous hint strings: {ambiguous_strings:?}"); | ||
| assert_eq!( | ||
| syscall_hint_strings.len(), | ||
| syscall_hint_strings_set.len(), | ||
| "Duplicate syscall hint strings." | ||
| ); | ||
|
|
||
| let first_intersection = | ||
| hint_strings_set.intersection(&hint_extension_strings_set).cloned().collect::<HashSet<_>>(); | ||
| let mut ambiguous_strings = first_intersection.intersection(&syscall_hint_strings_set); | ||
| let common_value = ambiguous_strings.next(); | ||
| assert!(common_value.is_none(), "Ambiguous hint strings: {common_value:?}"); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_syscall_compatibility_with_blockifier() { | ||
| let syscall_hint_strings = | ||
| SyscallHint::iter().map(|hint| hint.to_str()).collect::<HashSet<_>>(); | ||
| let blockifier_syscall_strings: HashSet<_> = SYSCALL_HINTS.iter().cloned().collect(); | ||
| assert_eq!(blockifier_syscall_strings, syscall_hint_strings); | ||
| } |