chore(blockifier): add range_check96_gas_cost #3641
Conversation
|
This change is |
|
Artifacts upload workflows: |
There was a problem hiding this comment.
Please apply this change in python as well
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @Yonatan-Starkware)
crates/blockifier/resources/versioned_constants_0_13_0.json line 79 at r1 (raw file):
"builtin_gas_costs": { "range_check": 70, "range_check96": 56,
In all versions except 13.4
Suggestion:
"range_check96": 0,
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/add_builtins_test
branch
2 times, most recently
from
e988cfd to
c952b8a
Compare
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yonatan-Starkware)
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/add_builtins_test
branch
2 times, most recently
from
abd302a to
ccf4981
Compare
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/add_builtins_test
branch
from
ccf4981 to
46167df
Compare
Yonatan-Starkware
force-pushed
the
yonatan/blockifier/add_range_check96_gas_cost
branch
from
af33d56 to
a470c66
Compare
There was a problem hiding this comment.
Please rebase this PR
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware, @noaov1, and @Yonatan-Starkware)
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/add_builtins_test
branch
2 times, most recently
from
35a241b to
2c2537a
Compare
Yonatan-Starkware
changed the base branch from
yonatank/blockifier/add_builtins_test
to
main-v0.13.4
Yonatan-Starkware
force-pushed
the
yonatan/blockifier/add_range_check96_gas_cost
branch
2 times, most recently
from
c6641d1 to
6eeb331
Compare
Yonatan-Starkware
force-pushed
the
yonatan/blockifier/add_range_check96_gas_cost
branch
from
6eeb331 to
84f4f57
Compare
There was a problem hiding this comment.
Reviewed 7 of 8 files at r3, 7 of 7 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @Yonatan-Starkware)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1)
crates/blockifier/resources/versioned_constants_0_13_0.json line 79 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
In all versions except 13.4
Done.
There was a problem hiding this comment.
Reviewed 7 of 8 files at r3, 7 of 7 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)
Yonatan-Starkware
deleted the
yonatan/blockifier/add_range_check96_gas_cost
branch
No description provided.