feat(blockifier): add ExecutableCallEntryPoint

[liorgold2]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-26T09:32:25Z
• Started at 2025-01-26T11:13:02Z
• Started at 2025-01-26T11:13:02Z
• Started at 2025-01-26T12:44:16Z
• Started at 2025-01-26T13:36:47Z
• Started at 2025-01-26T14:19:54Z
• Started at 2025-01-26T14:46:38Z
• Started at 2025-01-26T22:40:11Z
• Started at 2025-01-27T08:20:41Z
• Started at 2025-01-27T09:09:27Z
• Started at 2025-01-27T09:55:51Z
• Started at 2025-01-27T10:49:33Z
• Started at 2025-01-27T14:16:17Z
• Started at 2025-01-27T14:22:46Z
• Started at 2025-01-27T14:45:59Z

[elintul]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @liorgold2)

---

crates/blockifier/src/execution/entry_point.rs line 99 at r1 (raw file):

#[cfg_attr(feature = "transaction_serde", derive(serde::Deserialize))]
#[derive(Clone, Debug, Default, Eq, PartialEq, Serialize)]
pub struct CallEntryPointEx<ClassHashT> {

Suggestion:

TClassHash

---

crates/blockifier/src/execution/entry_point.rs line 99 at r1 (raw file):

#[cfg_attr(feature = "transaction_serde", derive(serde::Deserialize))]
#[derive(Clone, Debug, Default, Eq, PartialEq, Serialize)]
pub struct CallEntryPointEx<ClassHashT> {

Naming suggestions: CallEntryPoin[Variant,Phase,State].

Code quote:

CallEntryPointEx

---

crates/blockifier/src/execution/entry_point.rs line 106 at r1 (raw file):

    /// The class hash is not given if it can be deduced from the storage address.
    /// It is resolved prior to entry point's execution.
    pub class_hash: ClassHashT,

Cool, no need for phantom data when the generic type is directly used! 🔥

Code quote:

pub class_hash: ClassHashT,

---

crates/blockifier/src/execution/entry_point.rs line 122 at r1 (raw file):

pub type CallEntryPoint = CallEntryPointEx<Option<ClassHash>>;
pub type CallEntryPointResolved = CallEntryPointEx<ClassHash>;

Suggestion:

ExecutableCallEntryPoint

---

crates/blockifier/src/execution/entry_point.rs line 141 at r1 (raw file):

impl CallEntryPoint {
    pub fn execute(

Move to impl CallEntryPointEx<ClassHash> block to achieve what we want.

Code quote:

pub fn execute

---

crates/blockifier/src/execution/entry_point.rs line 233 at r1 (raw file):

    }

    fn as_resolved(self, class_hash: ClassHash) -> CallEntryPointResolved {

I'd move here the decision line (match storage_class_hash ...).

Suggestion:

fn resolve_for_execution(self, storage_class_hash: ClassHash) -> CallEntryPointResolved

[liorgold2]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @elintul)

---

crates/blockifier/src/execution/entry_point.rs line 99 at r1 (raw file):

Previously, elintul (Elin) wrote…

Naming suggestions: CallEntryPoin[Variant,Phase,State].

Done

---

crates/blockifier/src/execution/entry_point.rs line 99 at r1 (raw file):

#[cfg_attr(feature = "transaction_serde", derive(serde::Deserialize))]
#[derive(Clone, Debug, Default, Eq, PartialEq, Serialize)]
pub struct CallEntryPointEx<ClassHashT> {

Done.

---

crates/blockifier/src/execution/entry_point.rs line 122 at r1 (raw file):

pub type CallEntryPoint = CallEntryPointEx<Option<ClassHash>>;
pub type CallEntryPointResolved = CallEntryPointEx<ClassHash>;

Done.

[elintul]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @liorgold2)

[elintul]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

[elintul]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

[elintul]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

[elintul]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

[elintul]

Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)