-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(papyrus_p2p_sync): retry upon class manager client error #3894
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @ShahakShama)
crates/papyrus_p2p_sync/src/client/class.rs
line 40 at r1 (raw file):
// TODO(shahak): Verify class hash matches class manager response. report if not. // TODO(shahak): Try to avoid cloning. See if ClientError can contain the request. while let Err(err) = class_manager_client.add_class(class.clone()).await {
Add a timeout/max_num_attempts so this doesn't loop forever in case of an error.
crates/papyrus_p2p_sync/src/client/class.rs
line 53 at r1 (raw file):
// TODO(shahak): Test this flow. // TODO(shahak): Try to avoid cloning. See if ClientError can contain the request. while let Err(err) = class_manager_client
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)
crates/papyrus_p2p_sync/src/client/class.rs
line 40 at r1 (raw file):
Previously, noamsp-starkware wrote…
Add a timeout/max_num_attempts so this doesn't loop forever in case of an error.
The idea is to loop forever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)
No description provided.