feat(blockifier_test_utils): move functions from blockifier::test_utils and update dependencies #3931
Conversation
|
This change is |
rotem-starkware
requested review from
AvivYossef-starkware and
dorimedini-starkware
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_calldata
branch
from
52e2578 to
85c34cb
Compare
There was a problem hiding this comment.
Reviewed 24 of 24 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @rotem-starkware)
a discussion (no related file):
update the PR title to match the commit message (commitlint runs on the PR title, as this title is what will appear when you merge the PR)
a discussion (no related file):
looks good!
next time, please split into two PRs: one to create the (empty) crate, and one to move the function
crates/blockifier_test_utils/src/calldata.rs line 55 at r1 (raw file):
pub fn u64_from_usize(val: usize) -> u64 { val.try_into().expect("Conversion from usize to u64 should not fail.") }
this should not be in calldata.rs; please create a types.rs module for it
Code quote:
/// Conversion from usize to u64. May fail on architectures with over 64 bits
/// of address space.
pub fn u64_from_usize(val: usize) -> u64 {
val.try_into().expect("Conversion from usize to u64 should not fail.")
}
rotem-starkware
changed the title
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_calldata
branch
from
85c34cb to
f4796b7
Compare
rotem-starkware
changed the title
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @rotem-starkware)
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_calldata
branch
from
f4796b7 to
28f7a6c
Compare
rotem-starkware
changed the base branch from
graphite-base/3931
to
rotem/move_blockifier_test_utils_prep
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @rotem-starkware)
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_calldata
branch
from
28f7a6c to
3a23256
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @rotem-starkware)
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_calldata
branch
from
3a23256 to
2579028
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @rotem-starkware)
|
Benchmark movements: |
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_calldata
branch
from
2579028 to
f6948b8
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @rotem-starkware)
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_calldata
branch
2 times, most recently
from
1b0d72f to
9c10b08
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @rotem-starkware)
rotem-starkware
changed the base branch from
rotem/move_blockifier_test_utils_prep
to
graphite-base/3931
Previously, dorimedini-starkware wrote…
Done. |
rotem-starkware
force-pushed
the
graphite-base/3931
branch
from
c763b93 to
a53875d
Compare
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_calldata
branch
from
9c10b08 to
6a9f44a
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @rotem-starkware)
|
Previously, dorimedini-starkware wrote…
create the module inside the crate blockifier_test_utils? |
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @rotem-starkware)
crates/blockifier_test_utils/src/calldata.rs line 55 at r1 (raw file):
Previously, rotem-starkware wrote…
create the module inside the crate blockifier_test_utils?
yes
…ls and update dependencies
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_calldata
branch
from
6a9f44a to
f53d30e
Compare
|
Previously, dorimedini-starkware wrote…
Done. |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r9, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @dorimedini-starkware)
No description provided.