fix(starknet_class_manager): embed class-not-found flow in Option return type
#4030
+170
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
elintul
force-pushed
the
elin/class-manager/class-not-found-as-option
branch
5 times, most recently
from
aa6f23d to
21b2e63
Compare
ShahakShama
reviewed
Feb 9, 2025
There was a problem hiding this comment.
Reviewed 8 of 15 files at r1.
Reviewable status: 8 of 15 files reviewed, 3 unresolved discussions (waiting on @AlonLStarkWare, @noamsp-starkware, and @yair-starkware)
crates/papyrus_p2p_sync/src/server/test.rs line 486 at r1 (raw file):
.expect_get_sierra() .with(eq(class_hash)) .returning(|_| Ok(Some(contract_class.clone())));
Could you add a TODO on me to test the flow where it returns None
crates/starknet_gateway/src/sync_state_reader_test.rs line 195 at r1 (raw file):
.with(predicate::eq(class_hash)) .returning(move |_| { Ok(Some(ContractClass::V1((casm_contract_class.clone(), SierraVersion::default()))))
Could you add a TODO on me to test the flow where it returns None
crates/starknet_batcher/src/reader_with_class_manager_test.rs line 132 at r1 (raw file):
.with(predicate::eq(class_hash)) .returning(move |_| { Ok(Some(ContractClass::V1((casm_contract_class.clone(), SierraVersion::default()))))
Could you add a TODO on me to test the flow where it returns None
elintul
force-pushed
the
elin/class-manager/class-not-found-as-option
branch
from
21b2e63 to
0228d29
Compare
…eturn type Instead of an error variant. For two reasons: 1. `Option` is easier to streamline through abstraction layers; there are quire a few of those in the class manager E2E flow. 2. A class not found flow might be expected at times, it's more idiomatic to leave the decision of how to handle this to the caller, who has more context.
elintul
force-pushed
the
elin/class-manager/class-not-found-as-option
branch
from
0228d29 to
a275e6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of an error variant. For two reasons:
Optionis easier to streamline through abstraction layers; there are quire a few of those in the class manager E2E flow.