-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_integration_tests): sequencer simulator binary #4032
base: spr/main/7c11e54a
Are you sure you want to change the base?
Conversation
Artifacts upload workflows: |
44ce5cc
to
0963023
Compare
7705719
to
5aa46ca
Compare
0963023
to
23ea6c3
Compare
5aa46ca
to
c0f6149
Compare
23ea6c3
to
bb6b652
Compare
aedfbc6
to
6d14144
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion
crates/starknet_integration_tests/src/sequencer_simulator_utils.rs
line 54 at r1 (raw file):
pub async fn await_execution(&self, expected_block_number: BlockNumber) { await_execution(&self.monitoring_client, expected_block_number, 0, 0).await;
I prefer a fully qualified name for distinction.
Code quote:
await_execution
6b1cb44
to
d8f1e98
Compare
6d14144
to
7210400
Compare
commit-id:9e5db078
7210400
to
63f869d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)
crates/starknet_integration_tests/src/sequencer_simulator_utils.rs
line 54 at r1 (raw file):
Previously, lev-starkware wrote…
I prefer a fully qualified name for distinction.
Done.
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
Stack: