Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_integration_tests): sequencer simulator binary #4032

Open
wants to merge 1 commit into
base: spr/main/7c11e54a
Choose a base branch
from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

@nadin-Starkware nadin-Starkware force-pushed the spr/main/9e5db078 branch 2 times, most recently from 7705719 to 5aa46ca Compare February 9, 2025 10:54
@nadin-Starkware nadin-Starkware force-pushed the spr/main/9e5db078 branch 3 times, most recently from aedfbc6 to 6d14144 Compare February 9, 2025 12:04
Copy link

github-actions bot commented Feb 9, 2025

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.549 ms 35.772 ms 36.038 ms]
change: [+1.4429% +2.1071% +2.9320%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
3 (3.00%) high mild
11 (11.00%) high severe

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion


crates/starknet_integration_tests/src/sequencer_simulator_utils.rs line 54 at r1 (raw file):

    pub async fn await_execution(&self, expected_block_number: BlockNumber) {
        await_execution(&self.monitoring_client, expected_block_number, 0, 0).await;

I prefer a fully qualified name for distinction.

Code quote:

await_execution

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)


crates/starknet_integration_tests/src/sequencer_simulator_utils.rs line 54 at r1 (raw file):

Previously, lev-starkware wrote…

I prefer a fully qualified name for distinction.

Done.

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.816 ms 34.839 ms 34.864 ms]
change: [-3.9934% -2.4396% -1.0631%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants