feat(starknet_integration_tests): add snapshot tx generator fn

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-02-11T09:49:06Z
• Started at 2025-02-11T09:51:23Z
• Started at 2025-02-11T11:56:14Z
• Started at 2025-02-11T14:04:55Z
• Started at 2025-02-11T14:59:20Z
• Started at 2025-02-12T10:55:22Z
• Started at 2025-02-13T08:55:03Z

[noamsp-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• WIP_INTEGRATION_REVER_FLOW_TEST #4114
• test(starknet_integration_tests): add revert flow integration test #4076
• feat(starknet_integration_tests): add snapshot tx generator fn #4075 👈 (View in Graphite)
• feat(starknet_integration_tests): add update revert config #4074
• feat(starknet_state_sync): add revert_up_to_and_including option #3989
• feat(apollo_reverts): add revert blocks functionality #3988
• feat(papyrus_storage): add revert class manager marker #3987
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.758 ms 34.911 ms 35.162 ms]
change: [-4.6011% -2.8101% -1.1544%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
1 (1.00%) low severe
2 (2.00%) low mild
3 (3.00%) high mild
4 (4.00%) high severe

[ShahakShama]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noamsp-starkware)

---

crates/mempool_test_utils/src/starknet_api_test_utils.rs line 215 at r1 (raw file):

        let mut account_tx_generators = Vec::new();
        let nonce_manager = Rc::new(RefCell::new((*self.nonce_manager.borrow()).clone()));
        for tx_gen in self.account_tx_generators.iter() {

Change this to iterator functions

let  account_tx_generators = self.account_tx_generators.iter().map(...).collect();

---

crates/mempool_test_utils/src/starknet_api_test_utils.rs line 215 at r1 (raw file):

        let mut account_tx_generators = Vec::new();
        let nonce_manager = Rc::new(RefCell::new((*self.nonce_manager.borrow()).clone()));
        for tx_gen in self.account_tx_generators.iter() {

No need for iter in for loop. Just add & at the start of the container being iterated. If you accept my suggestion above this comment is irrelevant

---

crates/starknet_integration_tests/src/sequencer_manager.rs line 199 at r1 (raw file):

    }

    pub fn snapshot_tx_generator(&self) -> MultiAccountTransactionGenerator {

Change this to tx_generator which returns & and tx_generator_mut which returns &mut. In the test body call snapshot and assign the tx generator

[noamsp-starkware]

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @ShahakShama)

---

crates/mempool_test_utils/src/starknet_api_test_utils.rs line 215 at r1 (raw file):

Previously, ShahakShama wrote…

No need for iter in for loop. Just add & at the start of the container being iterated. If you accept my suggestion above this comment is irrelevant

Went with suggestion above.

---

crates/starknet_integration_tests/src/sequencer_manager.rs line 199 at r1 (raw file):

Previously, ShahakShama wrote…

Change this to tx_generator which returns & and tx_generator_mut which returns &mut. In the test body call snapshot and assign the tx generator

Why do we need tx_generator_mut?

[ShahakShama]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)

---

crates/starknet_integration_tests/src/sequencer_manager.rs line 199 at r1 (raw file):

Previously, noamsp-starkware wrote…

Why do we need tx_generator_mut?

answered in slack

[noamsp-starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

---

crates/starknet_integration_tests/src/sequencer_manager.rs line 199 at r1 (raw file):

Previously, ShahakShama wrote…

answered in slack

Done.

[ShahakShama]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

[Itay-Tsabary-Starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

---

-- commits line 2 at r4:
Commit scope (starknet_integration_tests) is incorrect.

Code quote:

- 8f46461: feat(starknet_integration_tests): add snapshot tx generator fn

[ShahakShama]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)